fix: resolve all failing tests across monorepo packages#15
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix renamed hook: re-export useDebounce as useSearchDebounce in api.ts - Fix DOM environment: configure happy-dom in root bunfig.toml for UI tests - Fix Button accessibility: forward aria-label prop in Button component - Fix date format: use d/MM/yyyy (non-padded day) in date formatter - Fix stale closure: use functional state update in DataTable sort handler - Add bun-types to tsconfig for proper bun:test type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDebounceasuseSearchDebounceinapps/web/src/lib/api.tsto match the expected import name after the hook was renamed inpackages/utilshappy-domenvironment in rootbunfig.tomlso UI component tests have access todocumentaria-labelprop through the Button component so icon-only buttons have an accessible namedd/MM/yyyytod/MM/yyyy(non-zero-padded day) in the date formatterprev => ...) in DataTable sort handler to avoid capturing stale statebun-typesto tsconfigtypesarray for properbun:testmodule resolutionVerification
All 13 tests pass and
tsc --noEmitreports 0 errors.Assumptions
bun:testtype errors were unintentional (bun-types was already installed but not referenced in tsconfig)d/MM/yyyy) based on test expectationsuseSearchDebounceexport is a compatibility alias for the renameduseDebouncehook